As an agency submitter, I need the DUNS validations to work properly so that I can submit my data without false positive errors

Description

See attached for the test file (CSV) used in this story. The XLSX version provides more context about the expected behavior for each line.

AC
1. Lines 15-16 triggered Warning D44: "Invalid DUNS number" for DUNS 077368509. This was an active DUNS on the date in question in SAM. I think this i related to #6 below.

2. Lines 20 to 38 (minus lines 27 and 35) triggered Warning D44: “Invalid DUNS number”.

  • This warning text for D44 must be more descriptive (i.e., does it mean that the DUNS wasn’t active in SAM on the action date? Or that it was never active?). First: why is it triggering in some instances of invalid numbers and not others? Second: it needs to explain why it's a warning and not an error (i.e., what logic made it only a warning in this case). AC: rewrite warning text to explain why it's triggering, and that it's failing based on active registration in SAM, not 'validity'

  • In the case of Line 20-21 and Lines 25-38 (minus 35), they already triggered a D44 error, so triggering a warning too seems redundant. AC: We should not be triggering both a D44 warning and a D44 error on the same line.

3. Lines 10-13 triggered no warnings/errors, but should have triggered an error because the field wasn’t the minimum length (minimum and maximum length are both 9). Note that each character should also be a number 0-9. AC: Create D44 variant (or another code, if appropriate) for below expected length error for this field

4. Line 20 triggered error D44 “For new assistance awards (ActionType = A), the DUNS must be active as of the ActionDate.” This isn’t wrong per se, but a wrong length error (since it’s 8 characters) would have been more pointedly descriptive of the issue. AC: See #3 above

5. Line 26 triggered error D44 “For new assistance awards (ActionType = A), the DUNS must be active as of the ActionDate.” This isn’t wrong per se, but a ‘This DUNS is not active (and has never been registered at all) with SAM” error would be more descriptive of the real problem, since this isn't even a real DUNS in the first place and thus isn't part of SAM either. AC: Create variant of D44 that explains more specifically what the error is here (or a new code, if appropriate)

6. Lines 28-34 triggered error D44 “For new assistance awards (ActionType = A), the DUNS must be active as of the ActionDate.” This DUNS was active on all these dates, but the date is just before the most recent SAM renewal so it’s failing. This is the reason you have to do the loop-through of the historical SAM data to properly run this validation. This has been a major issue with ASP and it would be better to turn off this validation entirely rather than have the same issue pop up in FABS testing (until we fix it). AC: this validation must be cognizant of the historical registration state of all SAM entities. Until we have this functionality built, we should not run this validation. This is the most important part of this story.

7. Lines 36-38 deal with ActionDates in the future. The associated DUNS doesn't expire in SAM until 3/31/2018, yet all three of these are failing with error D44 (with ActionDates of 20180330, 20180331, and 20180401). Lines 36 and 37 should fail for other reasons, but should not trigger error D44. Line 38 should still fail since it's after the expiration date in SAM.

Activity

Show:
Daniel Boos
July 24, 2017, 4:52 PM
Edited

Updated as of 7/21:
1. Error: AwardeeOrRecipientUniqueIdentifier Field must be blank for aggregate records (RecordType=1) and individual recipients (BusinessTypes includes 'P').
2. Error: AwardeeOrRecipientUniqueIdentifier is required for AssistanceType of 02, 03, 04, or 05 whose ActionDate after October 1, 2010, unless the record is an aggregate record (RecordType=1) or individual recipient (BusinessTypes includes 'P').
3. Error: If the record is not an aggregate record (RecordType=1) or individual recipient (BusinessTypes includes 'P') and AwardeeOrRecipientUniqueIdentifier is provided, it must be nine digits.
4. Error: For AssistanceType of 02, 03, 04, or 05 whose ActionDate is after October 1, 2010, AwardeeOrRecipientUniqueIdentifier must be found in our records, unless the record is an aggregate record (RecordType=1) or individual recipient (BusinessTypes includes 'P').
5. Error: For AssistanceType of 02, 03, 04, or 05 whose ActionDate is after October 1, 2010 and ActionType = A, AwardeeOrRecipientUniqueIdentifier must be active as of the ActionDate, unless the record is an aggregate record (RecordType=1) or individual recipient (BusinessTypes includes 'P'). This is an error because CorrectionLateDeleteIndicator is not C or the action date is after January 1, 2017.
6. Warning: For AssistanceType of 02, 03, 04, or 05 whose ActionDate is after October 1, 2010 and ActionType = A, AwardeeOrRecipientUniqueIdentifier should be active as of the ActionDate, unless the record is an aggregate record (RecordType=1) or individual recipient (BusinessTypes includes 'P'). This is a warning because CorrectionLateDeleteIndicator is C and the action date is before January 1, 2017.
7. Warning: For AssistanceType of 02, 03, 04, or 05 whose ActionDate is after October 1, 2010 and ActionType = B, C, or D, AwardeeOrRecipientUniqueIdentifier should be active on the ActionDate, unless the record is an aggregate record (RecordType=1) or individual recipient (BusinessTypes includes 'P').

Daniel Boos
July 21, 2017, 4:22 PM

After reviewing the ticket with the reporter, the rules to be implemented are as follows:
1. Error: For AssistanceType of 02, 03, 04, or 05 whose ActionDate is after October 1, 2010, DUNS is required.
2. Error: When provided, the DUNS must be nine digits.
3. Error: For AssistanceType of 02, 03, 04, or 05 whose ActionDate is after October 1, 2010, the DUNS must be found in our records.
4. Error: For AssistanceType of 02, 03, 04, or 05 whose ActionDate is after October 1, 2010 and ActionType = A, the DUNS must be active as of the ActionDate.
5. Warning: For AssistanceType of 02, 03, 04, or 05 whose ActionDate is after October 1, 2010 and ActionType = B, C, or D, the DUNS should be active on the ActionDate.
6. Error: The DUNS must be blank for aggregate records (i.e., when RecordType = 1) and individual recipients (i.e., when BusinessTypes includes "P").

Done
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Daniel Boos

Reporter

Ross Williford